Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide ASGI support with Django #655

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

GSVarsha
Copy link
Contributor

@GSVarsha GSVarsha commented Oct 24, 2024

Fix: Provide ASGI support with Django.

Why?

request.environ is available only with requests of type WSGIRequest and not ASGIRequest.
request.headers is only available from django-2.2.

Since we provide support for django>=1.11 we'll use request.META.

@GSVarsha GSVarsha added bug enhancement legacy_2.x Issues and PRs related to the legacy 2.x series. labels Oct 24, 2024
@GSVarsha GSVarsha added this to the H2-2024 milestone Oct 24, 2024
@GSVarsha GSVarsha self-assigned this Oct 24, 2024
@GSVarsha GSVarsha force-pushed the django-asgi-support branch from 1364f81 to 5b6d76b Compare October 24, 2024 07:17
Signed-off-by: Varsha GS <varsha.gs@ibm.com>
@GSVarsha GSVarsha force-pushed the django-asgi-support branch from 5b6d76b to 86d15b5 Compare October 24, 2024 09:35
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Copy link
Contributor

@CagriYonca CagriYonca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pvital pvital merged commit 86d15b5 into legacy_2.x Oct 24, 2024
13 of 14 checks passed
@pvital pvital deleted the django-asgi-support branch October 24, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement legacy_2.x Issues and PRs related to the legacy 2.x series. Review & Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants